This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Add interface for word related functions #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,6 +107,9 @@ def cppyy_version(): | |||
| cppyy.cppdef("#define HPCOMBI_CONSTEXPR_FUN_ARGS") | |||
|
|
|||
| cppyy.include("libsemigroups/libsemigroups.hpp") | |||
There was a problem hiding this comment.
I think you can fix this by doing:
if compare_version_numbers(libsemigroups_version(), "1.1.0") and not compare_version_numbers("1.3.0", libsemigroups_version()):
libsemigroups_cppyy/__init__.py
Outdated
| @@ -126,6 +129,7 @@ def cppyy_version(): | |||
| from libsemigroups_cppyy.schreier_sims import SchreierSims | |||
| from libsemigroups_cppyy.transf import * | |||
| from libsemigroups_cppyy.todd_coxeter import ToddCoxeter | |||
| from libsemigroups_cppyy.word import number_of_words, cbegin_wilo, cend_wilo, wilo, cbegin_wislo, cend_wislo, wislo, cbegin_sislo, cend_sislo, sislo, cbegin_silo, cend_silo, silo | |||
There was a problem hiding this comment.
also put these lines inside an "if"
|
Please add some tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions related to words described in https://libsemigroups.readthedocs.io/en/latest/words.html